Skip to content

Commit 6a1bb08

Browse files
committed
Merge branch 'da/mergetools-special-case-xxdiff-exit-128'
The xxdiff difftool backend can exit with status 128, which the difftool-helper that launches the backend takes as a significant failure, when it is not significant at all. Work it around. * da/mergetools-special-case-xxdiff-exit-128: mergetools/xxdiff: prevent segfaults from stopping difftool
2 parents ef16391 + 571f434 commit 6a1bb08

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

mergetools/xxdiff

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ diff_cmd () {
33
-R 'Accel.Search: "Ctrl+F"' \
44
-R 'Accel.SearchForward: "Ctrl+G"' \
55
"$LOCAL" "$REMOTE"
6+
7+
# xxdiff can segfault on binary files which are often uninteresting.
8+
# Do not allow segfaults to stop us from continuing on to the next file.
9+
if test $? = 128
10+
then
11+
return 1
12+
fi
613
}
714

815
merge_cmd () {

0 commit comments

Comments
 (0)