Skip to content

Commit 6ea3b67

Browse files
pyokagangitster
authored andcommitted
am --abort: keep unrelated commits on unborn branch
Since 7b3b7e3 (am --abort: keep unrelated commits since the last failure and warn, 2010-12-21), git-am would refuse to rewind HEAD if commits were made since the last git-am failure. This check was implemented in safe_to_abort(), which checked to see if HEAD's hash matched the abort-safety file. However, this check was skipped if the abort-safety file was empty, which can happen if git-am failed while on an unborn branch. As such, if any commits were made since then, they would be discarded. Fix this by carrying on the abort safety check even if the abort-safety file is empty. Signed-off-by: Paul Tan <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e06764c commit 6ea3b67

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

git-am.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ safe_to_abort () {
8686
return 1
8787
fi
8888

89-
if ! test -s "$dotest/abort-safety"
89+
if ! test -f "$dotest/abort-safety"
9090
then
9191
return 0
9292
fi

t/t4151-am-abort.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,4 +142,15 @@ test_expect_success 'am -3 --abort on unborn branch removes applied commits' '
142142
test refs/heads/orphan = "$(git symbolic-ref HEAD)"
143143
'
144144

145+
test_expect_success 'am --abort on unborn branch will keep local commits intact' '
146+
git checkout -f --orphan orphan &&
147+
git reset &&
148+
test_must_fail git am 0004-*.patch &&
149+
test_commit unrelated2 &&
150+
git rev-parse HEAD >expect &&
151+
git am --abort &&
152+
git rev-parse HEAD >actual &&
153+
test_cmp expect actual
154+
'
155+
145156
test_done

0 commit comments

Comments
 (0)