Skip to content

Commit 6f9142b

Browse files
dschoGit for Windows Build Agent
authored andcommitted
win32: ensure that localtime_r() is declared even in i686 builds
The `__MINGW64__` constant is defined, surprise, surprise, only when building for a 64-bit CPU architecture. Therefore using it as a guard to define `_POSIX_C_SOURCE` (so that `localtime_r()` is declared, among other functions) is not enough, we also need to check `__MINGW32__`. Technically, the latter constant is defined even for 64-bit builds. But let's make things a bit easier to understand by testing for both constants. Making it so fixes this compile warning (turned error in GCC v14.1): archive-zip.c: In function 'dos_time': archive-zip.c:612:9: error: implicit declaration of function 'localtime_r'; did you mean 'localtime_s'? [-Wimplicit-function-declaration] 612 | localtime_r(&time, &tm); | ^~~~~~~~~~~ | localtime_s Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 81112a8 commit 6f9142b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compat/posix.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
#define UNUSED
4646
#endif
4747

48-
#ifdef __MINGW64__
48+
#if defined(__MINGW32__) || defined(__MINGW64__)
4949
#define _POSIX_C_SOURCE 1
5050
#elif defined(__sun__)
5151
/*

0 commit comments

Comments
 (0)