Merge branch 'jx/cap-object-info-uninitialized-fix'

gitster · gitster · commit 714be4c3acd6 · 2023-04-11T13:49:13.000-07:00
Correct use of an uninitialized structure member.

* jx/cap-object-info-uninitialized-fix:
  object-info: init request_info before reading arg
diff --git a/protocol-caps.c b/protocol-caps.c
@@ -79,7 +79,7 @@ static void send_info(struct repository *r, struct packet_writer *writer,
 
 int cap_object_info(struct repository *r, struct packet_reader *request)
 {
-	struct requested_info info;
+	struct requested_info info = { 0 };
 	struct packet_writer writer;
 	struct string_list oid_str_list = STRING_LIST_INIT_DUP;
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ static void send_info(struct repository r, struct packet_writer writer,`
`79`	`79`
`80`	`80`	`int cap_object_info(struct repository r, struct packet_reader request)`
`81`	`81`	`{`
`82`		`- struct requested_info info;`
	`82`	`+ struct requested_info info = { 0 };`
`83`	`83`	`struct packet_writer writer;`
`84`	`84`	`struct string_list oid_str_list = STRING_LIST_INIT_DUP;`
`85`	`85`