Skip to content

Commit 74cf9bd

Browse files
Ramsay Jonesgitster
authored andcommitted
engine.pl: Fix a recent breakage of the buildsystem generator
Commit ade2ca0 (Do not try to remove directories when removing old links, 2009-10-27) added an expression to a 'test' using an '-o' or connective. This resulted in the buildsystem generator mistaking a conditional 'rm' for a linker command. In order to fix the breakage, we filter out all 'test' commands before then attempting to identify the commands of interest. Signed-off-by: Ramsay Jones <[email protected]> Acked-by: Sebastian Schuberth <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent af82559 commit 74cf9bd

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

contrib/buildsystems/engine.pl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,11 @@ sub parseMakeOutput
135135
}
136136
} while($ate_next);
137137

138+
if ($text =~ /^test /) {
139+
# options to test (eg -o) may be mistaken for linker options
140+
next;
141+
}
142+
138143
if($text =~ / -c /) {
139144
# compilation
140145
handleCompileLine($text, $line);
@@ -180,9 +185,6 @@ sub parseMakeOutput
180185
# } elsif ($text =~ /generate-cmdlist\.sh/) {
181186
# # command for generating list of commands
182187
#
183-
# } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
184-
# # commands removing executables, if they exist
185-
#
186188
# } elsif ($text =~ /new locations or Tcl/) {
187189
# # command for detecting Tcl/Tk changes
188190
#

0 commit comments

Comments
 (0)