Skip to content

Commit 7c1d34f

Browse files
ayu-chgitster
authored andcommitted
t6423: fix suppression of Git’s exit code in tests
Some test in t6423 supress Git's exit code, which can cause test failures go unnoticed. Specifically using git <subcommand> | <other-command> masks potential failures of the Git command. This commit ensures that Git's exit status is correctly propogated by: - Avoiding pipes that suppress exit codes. Signed-off-by: Ayush Chandekar <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bc204b7 commit 7c1d34f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

t/t6423-merge-rename-directories.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5071,7 +5071,8 @@ test_expect_success '12i: Directory rename causes rename-to-self' '
50715071
test_path_is_file source/bar &&
50725072
test_path_is_file source/baz &&
50735073
5074-
git ls-files | uniq >tracked &&
5074+
git ls-files >actual &&
5075+
uniq <actual >tracked &&
50755076
test_line_count = 3 tracked &&
50765077
50775078
git status --porcelain -uno >actual &&
@@ -5129,7 +5130,8 @@ test_expect_success '12j: Directory rename to root causes rename-to-self' '
51295130
test_path_is_file bar &&
51305131
test_path_is_file baz &&
51315132
5132-
git ls-files | uniq >tracked &&
5133+
git ls-files >actual &&
5134+
uniq <actual >tracked &&
51335135
test_line_count = 3 tracked &&
51345136
51355137
git status --porcelain -uno >actual &&
@@ -5187,7 +5189,8 @@ test_expect_success '12k: Directory rename with sibling causes rename-to-self' '
51875189
test_path_is_file dirA/bar &&
51885190
test_path_is_file dirA/baz &&
51895191
5190-
git ls-files | uniq >tracked &&
5192+
git ls-files >actual &&
5193+
uniq <actual >tracked &&
51915194
test_line_count = 3 tracked &&
51925195
51935196
git status --porcelain -uno >actual &&

0 commit comments

Comments
 (0)