Skip to content

Commit 7fbea9a

Browse files
committed
Merge branch 'mk/clone-recurse-submodules' into seen
* mk/clone-recurse-submodules: clone: set submodule.recurse=true if user enables feature.experimental flag
2 parents f769951 + c551037 commit 7fbea9a

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

builtin/clone.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,6 +874,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
874874
struct remote *remote;
875875
int err = 0, complete_refs_before_fetch = 1;
876876
int submodule_progress;
877+
int experimental_flag;
877878

878879
struct transport_ls_refs_options transport_ls_refs_options =
879880
TRANSPORT_LS_REFS_OPTIONS_INIT;
@@ -1015,6 +1016,11 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
10151016
strbuf_detach(&sb, NULL));
10161017
}
10171018

1019+
if(!git_config_get_bool("feature.experimental", &experimental_flag) &&
1020+
experimental_flag) {
1021+
string_list_append(&option_config, "submodule.recurse=true");
1022+
}
1023+
10181024
if (option_required_reference.nr &&
10191025
option_optional_reference.nr)
10201026
die(_("clone --recursive is not compatible with "

t/t5606-clone-options.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,18 @@ test_expect_success 'setup' '
1616
1717
'
1818

19+
test_expect_success 'feature.experimental flag manipulates submodule.recurse value' '
20+
21+
test_config_global feature.experimental true &&
22+
git clone --recurse-submodules parent clone_recurse_true &&
23+
test_cmp_config -C clone_recurse_true true submodule.recurse &&
24+
25+
test_config_global feature.experimental false &&
26+
git clone --recurse-submodules parent clone_recurse_false &&
27+
test_expect_code 1 git -C clone_recurse_false config --get submodule.recurse
28+
29+
'
30+
1931
test_expect_success 'clone -o' '
2032
2133
git clone -o foo parent clone-o &&

0 commit comments

Comments
 (0)