Skip to content

Commit 840d7e5

Browse files
szedergitster
authored andcommitted
completion: complete more values of more 'color.*' configuration variables
Most 'color.*' configuration variables, with the sole exception of 'color.pager', accept the same set of values, but our completion script recognizes only about half of them. We could explicitly add all those missing variables, but let's try to reduce future maintenance burden, and use the catch-all 'color.*' pattern instead, so this list won't get out of sync when a similar new configuration variable accepting the same values is introduced [1]. Furthermore, their documentation explicitly mentions that they all accept the standard boolean values 'false' and 'true' as well, so list these, too, among the possible values. [1] OTOH, there will be a maintenance burden if ever a new 'color.something' is introduced which doesn't accept the same set of values. We'll see which one happens first... Signed-off-by: SZEDER Gábor <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 08a1217 commit 840d7e5

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

contrib/completion/git-completion.bash

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2277,11 +2277,6 @@ _git_config ()
22772277
__gitcomp "$__git_merge_strategies"
22782278
return
22792279
;;
2280-
color.branch|color.diff|color.interactive|\
2281-
color.showbranch|color.status|color.ui)
2282-
__gitcomp "always never auto"
2283-
return
2284-
;;
22852280
color.pager)
22862281
__gitcomp "false true"
22872282
return
@@ -2293,6 +2288,10 @@ _git_config ()
22932288
"
22942289
return
22952290
;;
2291+
color.*)
2292+
__gitcomp "false true always never auto"
2293+
return
2294+
;;
22962295
diff.submodule)
22972296
__gitcomp "$__git_diff_submodule_formats"
22982297
return

0 commit comments

Comments
 (0)