Skip to content

Commit 86622d6

Browse files
dschoGit for Windows Build Agent
authored andcommitted
mingw: include the full version information in the resources
This fixes #723 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 02fae03 commit 86622d6

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1822,9 +1822,14 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES
18221822
$(QUIET_GEN)$(cmd_munge_script) && \
18231823
mv $@+ $@
18241824

1825+
ifeq (,$(findstring .windows.,$(GIT_VERSION)))
1826+
RC_VERSION_DEFS := $(join -DMAJOR= -DMINOR= -DMICRO=, $(wordlist 1,3,$(subst -, ,$(subst ., ,$(subst .windows., ,$(GIT_VERSION)))))) -DPATCHLEVEL=0
1827+
else
1828+
RC_VERSION_DEFS := $(join -DMAJOR= -DMINOR= -DMICRO= -DPATCHLEVEL=, $(wordlist 1,4,$(subst -, ,$(subst ., ,$(subst .rc, ,$(subst .windows., ,$(GIT_VERSION)))))))
1829+
endif
1830+
18251831
git.res: git.rc GIT-VERSION-FILE
1826-
$(QUIET_RC)$(RC) \
1827-
$(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \
1832+
$(QUIET_RC)$(RC) $(RC_VERSION_DEFS) \
18281833
-DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" $< -o $@
18291834

18301835
# This makes sure we depend on the NO_PERL setting itself.

git.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
1 VERSIONINFO
2-
FILEVERSION MAJOR,MINOR,0,0
3-
PRODUCTVERSION MAJOR,MINOR,0,0
2+
FILEVERSION MAJOR,MINOR,MICRO,PATCHLEVEL
3+
PRODUCTVERSION MAJOR,MINOR,MICRO,PATCHLEVEL
44
BEGIN
55
BLOCK "StringFileInfo"
66
BEGIN

0 commit comments

Comments
 (0)