Skip to content

Commit 86ca3eb

Browse files
committed
Merge branch 'jt/t5551-protocol-v2-does-not-have-half-auth' into next
Test update. * jt/t5551-protocol-v2-does-not-have-half-auth: t5551: mark half-auth no-op fetch test as v0-only
2 parents d49336d + 3a9e1ad commit 86ca3eb

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

t/t5551-http-fetch-smart.sh

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,17 @@ test_expect_success 'clone from auth-only-for-objects repository' '
164164

165165
test_expect_success 'no-op half-auth fetch does not require a password' '
166166
set_askpass wrong &&
167-
git --git-dir=half-auth fetch &&
167+
168+
# NEEDSWORK: When using HTTP(S), protocol v0 supports a "half-auth"
169+
# configuration with authentication required only when downloading
170+
# objects and not refs, by having the HTTP server only require
171+
# authentication for the "git-upload-pack" path and not "info/refs".
172+
# This is not possible with protocol v2, since both objects and refs
173+
# are obtained from the "git-upload-pack" path. A solution to this is
174+
# to teach the server and client to be able to inline ls-refs requests
175+
# as an Extra Parameter (see pack-protocol.txt), so that "info/refs"
176+
# can serve refs, just like it does in protocol v0.
177+
GIT_TEST_PROTOCOL_VERSION=0 git --git-dir=half-auth fetch &&
168178
expect_askpass none
169179
'
170180

0 commit comments

Comments
 (0)