Skip to content

Commit 88c6e9d

Browse files
peffgitster
authored andcommitted
test-lib: --valgrind should not override --verbose-log
The --verbose test option cannot be used with test harnesses like "prove". Instead, you must use --verbose-log. Since the --valgrind option implies --verbose, that means that it cannot be used with prove. I.e., this does not work: prove t0000-basic.sh :: --valgrind You'd think it could be fixed by doing: prove t0000-basic.sh :: --valgrind --verbose-log but that doesn't work either, because the implied --verbose takes precedence over --verbose-log. If the user has given us a specific option, we should prefer that. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 3ec7d70 commit 88c6e9d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/test-lib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ then
274274
test -z "$verbose" && verbose_only="$valgrind_only"
275275
elif test -n "$valgrind"
276276
then
277-
verbose=t
277+
test -z "$verbose_log" && verbose=t
278278
fi
279279

280280
if test -n "$color"

0 commit comments

Comments
 (0)