Skip to content

Commit 8f92c77

Browse files
Jajcusgitster
authored andcommitted
pull: do not abuse 'break' inside a shell 'case'
It is not C. The code would break under mksh when 'pull.ff' is set: $ git pull /usr/lib/git-core/git-pull[67]: break: can't break Already up-to-date. Signed-off-by: Jacek Konieczny <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent bce14aa commit 8f92c77

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

git-pull.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,9 @@ pull_ff=$(git config pull.ff)
5858
case "$pull_ff" in
5959
false)
6060
no_ff=--no-ff
61-
break
6261
;;
6362
only)
6463
ff_only=--ff-only
65-
break
6664
;;
6765
esac
6866

0 commit comments

Comments
 (0)