Skip to content

Commit 91527e5

Browse files
committed
Merge branch 'maint'
* maint: Update draft release notes to 1.7.9.3 for the last time http.proxy: also mention https_proxy and all_proxy t0300: work around bug in dash 0.5.6 t5512 (ls-remote): modernize style tests: fix spurious error when run directly with Solaris /usr/xpg4/bin/sh
2 parents 38916c5 + ead8eb8 commit 91527e5

File tree

5 files changed

+44
-31
lines changed

5 files changed

+44
-31
lines changed

Documentation/RelNotes/1.7.9.3.txt

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,41 @@ Fixes since v1.7.9.2
1111
to link the binary with -lintl even when libintl.h is missing from
1212
the system.
1313

14+
* When the filter driver exits before reading the content before the
15+
main git process writes the contents to be filtered to the pipe to
16+
it, the latter could be killed with SIGPIPE instead of ignoring
17+
such an event as an error.
18+
1419
* "git add --refresh <pathspec>" used to warn about unmerged paths
1520
outside the given pathspec.
1621

22+
* The bulk check-in codepath in "git add" streamed contents that
23+
needs smudge/clean filters without running them, instead of punting
24+
and delegating to the codepath to run filters after slurping
25+
everything to core.
26+
27+
* "git branch --with $that" assumed incorrectly that the user will never
28+
ask the question with nonsense value in $that.
29+
30+
* "git bundle create" produced a corrupt bundle file upon seeing
31+
commits with excessively long subject line.
32+
33+
* When a remote helper exits before reading the blank line from the
34+
main git process to signal the end of commands, the latter could be
35+
killed with SIGPIPE. Instead we should ignore such event as a
36+
non-error.
37+
1738
* The commit log template given with "git merge --edit" did not have
1839
a short instructive text like what "git commit" gives.
1940

41+
* "git rev-list --verify-objects -q" omitted the extra verification
42+
it needs to do over "git rev-list --objects -q" by mistake.
43+
2044
* "gitweb" used to drop warnings in the log file when "heads" view is
2145
accessed in a repository whose HEAD does not point at a valid
2246
branch.
2347

48+
* An invalid regular expression pattern given by an end user made
49+
"gitweb" to return garbled response.
50+
2451
Also contains minor fixes and documentation updates.

Documentation/config.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1275,9 +1275,10 @@ help.autocorrect::
12751275
This is the default.
12761276

12771277
http.proxy::
1278-
Override the HTTP proxy, normally configured using the 'http_proxy'
1279-
environment variable (see linkgit:curl[1]). This can be overridden
1280-
on a per-remote basis; see remote.<name>.proxy
1278+
Override the HTTP proxy, normally configured using the 'http_proxy',
1279+
'https_proxy', and 'all_proxy' environment variables (see
1280+
`curl(1)`). This can be overridden on a per-remote basis; see
1281+
remote.<name>.proxy
12811282

12821283
http.cookiefile::
12831284
File containing previously stored cookie lines which should be used

t/t0300-credentials.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,13 @@ test_expect_success 'setup helper scripts' '
88
cat >dump <<-\EOF &&
99
whoami=`echo $0 | sed s/.*git-credential-//`
1010
echo >&2 "$whoami: $*"
11-
while IFS== read key value; do
11+
OIFS=$IFS
12+
IFS==
13+
while read key value; do
1214
echo >&2 "$whoami: $key=$value"
1315
eval "$key=$value"
1416
done
17+
IFS=$OIFS
1518
EOF
1619
1720
write_script git-credential-useless <<-\EOF &&

t/t5512-ls-remote.sh

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ test_description='git ls-remote'
55
. ./test-lib.sh
66

77
test_expect_success setup '
8-
98
>file &&
109
git add file &&
1110
test_tick &&
@@ -18,45 +17,33 @@ test_expect_success setup '
1817
) >expected.all &&
1918
2019
git remote add self "$(pwd)/.git"
21-
2220
'
2321

2422
test_expect_success 'ls-remote --tags .git' '
25-
2623
git ls-remote --tags .git >actual &&
2724
test_cmp expected.tag actual
28-
2925
'
3026

3127
test_expect_success 'ls-remote .git' '
32-
3328
git ls-remote .git >actual &&
3429
test_cmp expected.all actual
35-
3630
'
3731

3832
test_expect_success 'ls-remote --tags self' '
39-
4033
git ls-remote --tags self >actual &&
4134
test_cmp expected.tag actual
42-
4335
'
4436

4537
test_expect_success 'ls-remote self' '
46-
4738
git ls-remote self >actual &&
4839
test_cmp expected.all actual
49-
5040
'
5141

5242
test_expect_success 'dies when no remote specified and no default remotes found' '
53-
5443
test_must_fail git ls-remote
55-
5644
'
5745

5846
test_expect_success 'use "origin" when no remote specified' '
59-
6047
URL="$(pwd)/.git" &&
6148
echo "From $URL" >exp_err &&
6249
@@ -65,18 +52,14 @@ test_expect_success 'use "origin" when no remote specified' '
6552
6653
test_cmp exp_err actual_err &&
6754
test_cmp expected.all actual
68-
6955
'
7056

7157
test_expect_success 'suppress "From <url>" with -q' '
72-
7358
git ls-remote -q 2>actual_err &&
7459
test_must_fail test_cmp exp_err actual_err
75-
7660
'
7761

7862
test_expect_success 'use branch.<name>.remote if possible' '
79-
8063
#
8164
# Test that we are indeed using branch.<name>.remote, not "origin", even
8265
# though the "origin" remote has been set.
@@ -99,14 +82,13 @@ test_expect_success 'use branch.<name>.remote if possible' '
9982
git ls-remote 2>actual_err >actual &&
10083
test_cmp exp_err actual_err &&
10184
test_cmp exp actual
102-
10385
'
10486

105-
cat >exp <<EOF
106-
fatal: 'refs*master' does not appear to be a git repository
107-
fatal: The remote end hung up unexpectedly
108-
EOF
10987
test_expect_success 'confuses pattern as remote when no remote specified' '
88+
cat >exp <<-\EOF &&
89+
fatal: '\''refs*master'\'' does not appear to be a git repository
90+
fatal: The remote end hung up unexpectedly
91+
EOF
11092
#
11193
# Do not expect "git ls-remote <pattern>" to work; ls-remote, correctly,
11294
# confuses <pattern> for <remote>. Although ugly, this behaviour is akin
@@ -120,7 +102,6 @@ test_expect_success 'confuses pattern as remote when no remote specified' '
120102
# role as a pattern.
121103
test_must_fail git ls-remote refs*master >actual 2>&1 &&
122104
test_cmp exp actual
123-
124105
'
125106

126107
test_expect_success 'die with non-2 for wrong repository even with --exit-code' '

t/test-lib.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,11 @@ TZ=UTC
4242
TERM=dumb
4343
export LANG LC_ALL PAGER TERM TZ
4444
EDITOR=:
45-
unset VISUAL
46-
unset EMAIL
47-
unset LANGUAGE
48-
unset $(perl -e '
45+
# A call to "unset" with no arguments causes at least Solaris 10
46+
# /usr/xpg4/bin/sh and /bin/ksh to bail out. So keep the unsets
47+
# deriving from the command substitution clustered with the other
48+
# ones.
49+
unset VISUAL EMAIL LANGUAGE $(perl -e '
4950
my @env = keys %ENV;
5051
my $ok = join("|", qw(
5152
TRACE

0 commit comments

Comments
 (0)