Skip to content

Commit 92420d0

Browse files
dschoGit for Windows Build Agent
authored andcommitted
Merge branch 'move-gfw-system-config-to-top-level'
Make `git config --system` work like you think it should on Windows: it should edit the file that is located in `<Git>\etc\gitconfig`. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents 48a029b + dc69956 commit 92420d0

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

config.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,9 +1662,11 @@ static int git_config_from_blob_ref(config_fn_t fn,
16621662

16631663
const char *git_etc_gitconfig(void)
16641664
{
1665-
static const char *system_wide;
1666-
if (!system_wide)
1665+
static char *system_wide;
1666+
if (!system_wide) {
16671667
system_wide = system_path(ETC_GITCONFIG);
1668+
normalize_path_copy(system_wide, system_wide);
1669+
}
16681670
return system_wide;
16691671
}
16701672

config.mak.uname

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,11 @@ ifeq ($(uname_S),Windows)
424424
NO_POSIX_GOODIES = UnfortunatelyYes
425425
NATIVE_CRLF = YesPlease
426426
DEFAULT_HELP_FORMAT = html
427+
ifeq (/mingw64,$(subst 32,64,$(prefix)))
428+
# Move system config into top-level /etc/
429+
ETC_GITCONFIG = ../etc/gitconfig
430+
ETC_GITATTRIBUTES = ../etc/gitattributes
431+
endif
427432

428433
CC = compat/vcbuild/scripts/clink.pl
429434
AR = compat/vcbuild/scripts/lib.pl
@@ -668,6 +673,11 @@ else
668673
USE_LIBPCRE = YesPlease
669674
NO_CURL =
670675
USE_NED_ALLOCATOR = YesPlease
676+
ifeq (/mingw64,$(subst 32,64,$(prefix)))
677+
# Move system config into top-level /etc/
678+
ETC_GITCONFIG = ../etc/gitconfig
679+
ETC_GITATTRIBUTES = ../etc/gitattributes
680+
endif
671681
else
672682
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO
673683
NO_CURL = YesPlease

0 commit comments

Comments
 (0)