Skip to content

Commit 92e24c8

Browse files
committed
ReviewingGuidelines: encourage positive reviews more
I saw some contributors hesitate to give a positive review on patches by their coworkers. When written well, a positive review does not have to be a hollow "looks good" that rubber stamps an useless approval on a topic that is not interesting to others. Let's add a few paragraphs to encourage positive reviews, which is a bit harder to give than a review to point out things to improve. Signed-off-by: Junio C Hamano <[email protected]>
1 parent c2b3f2b commit 92e24c8

File tree

1 file changed

+21
-4
lines changed

1 file changed

+21
-4
lines changed

Documentation/ReviewingGuidelines.txt

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,29 @@ guidance, and concrete tips for interacting with patches on the mailing list.
7272
could fix it. This not only helps the author to understand and fix the issue,
7373
it also deepens and improves your understanding of the topic.
7474

75-
- Reviews do not need to exclusively point out problems. Feel free to "think out
75+
- Reviews do not need to exclusively point out problems. Positive
76+
reviews indicate that it is not only the original author of the
77+
patches who care about the issue the patches address, and are
78+
highly encouraged.
79+
80+
- Do not hesitate to give positive reviews on a series from your
81+
work colleague. If your positive review is written well, it will
82+
not make you look as if you two are representing corporate
83+
interest on a series that is otherwise uninteresting to other
84+
community members and shoving it down their throat.
85+
86+
- Write a positive review in such a way that others can understand
87+
why you support the goal, the approach, and the implementation the
88+
patches took. Make sure to demonstrate that you did thoroughly read
89+
the series and understood problem area well enough to be able to
90+
say that the patches are written well. Feel free to "think out
7691
loud" in your review: describe how you read & understood a complex section of
7792
a patch, ask a question about something that confused you, point out something
78-
you found exceptionally well-written, etc. In particular, uplifting feedback
79-
goes a long way towards encouraging contributors to participate more actively
80-
in the Git community.
93+
you found exceptionally well-written, etc.
94+
95+
- In particular, uplifting feedback goes a long way towards
96+
encouraging contributors to participate more actively in the Git
97+
community.
8198

8299
==== Performing your review
83100
- Provide your review comments per-patch in a plaintext "Reply-All" email to the

0 commit comments

Comments
 (0)