Skip to content

Commit 942530d

Browse files
dschoGit for Windows Build Agent
authored andcommitted
mingw: change core.fsyncObjectFiles = 1 by default
From the documentation of said setting: This boolean will enable fsync() when writing object files. This is a total waste of time and effort on a filesystem that orders data writes properly, but can be useful for filesystems that do not use journalling (traditional UNIX filesystems) or that only journal metadata and not file contents (OS X’s HFS+, or Linux ext3 with "data=writeback"). The most common file system on Windows (NTFS) does not guarantee that order, therefore a sudden loss of power (or any other event causing an unclean shutdown) would cause corrupt files (i.e. files filled with NULs). Therefore we need to change the default. Note that the documentation makes it sound as if this causes really bad performance. In reality, writing loose objects is something that is done only rarely, and only a handful of files at a time. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 2027472 commit 942530d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include "win32.h"
1717
#include "win32/lazyload.h"
1818
#include "wrapper.h"
19+
#include "write-or-die.h"
1920
#include <aclapi.h>
2021
#include <conio.h>
2122
#include <sddl.h>
@@ -3325,6 +3326,7 @@ int wmain(int argc, const wchar_t **wargv)
33253326
#endif
33263327

33273328
maybe_redirect_std_handles();
3329+
fsync_object_files = 1;
33283330

33293331
/* determine size of argv and environ conversion buffer */
33303332
maxlen = wcslen(wargv[0]);

0 commit comments

Comments
 (0)