Skip to content

Commit 96728b2

Browse files
peffgitster
authored andcommitted
verify-tag: drop signal.h include
There's no reason verify-tag.c needs to include signal.h. It's already in git-compat-util.h, which we properly include as the first header. And there doesn't seem to be a particular reason for this include; it's just an artifact from the file creation in 2ae68fc (Make verify-tag a builtin., 2007-07-27). Likewise verify-commit.c has the same issue, probably because it was created using verify-tag as a template in d07b00b (verify-commit: scriptable commit signature verification, 2014-06-23). These includes are probably just redundant, and not hurting anything by circumventing the order that git-compat-util.h tries to impose, since we'll always have loaded git-compat-util by the time we get to these. So this is just a cleanup, and shouldn't fix or break any platforms. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b697d92 commit 96728b2

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

builtin/verify-commit.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "repository.h"
1313
#include "commit.h"
1414
#include "run-command.h"
15-
#include <signal.h>
1615
#include "parse-options.h"
1716
#include "gpg-interface.h"
1817

builtin/verify-tag.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include "builtin.h"
1111
#include "tag.h"
1212
#include "run-command.h"
13-
#include <signal.h>
1413
#include "parse-options.h"
1514
#include "gpg-interface.h"
1615
#include "ref-filter.h"

0 commit comments

Comments
 (0)