Skip to content

Commit 969563c

Browse files
ismailGit for Windows Build Agent
authored andcommitted
Enable DEP and ASLR
Enable DEP (Data Execution Prevention) and ASLR (Address Space Layout Randomization) support. This applies to both 32bit and 64bit builds and makes it substantially harder to exploit security holes in Git by offering a much more unpredictable attack surface. ASLR interferes with GDB's ability to set breakpoints. A similar issue holds true when compiling with -O2 (in which case single-stepping is messed up because GDB cannot map the code back to the original source code properly). Therefore we simply enable ASLR only when an optimization flag is present in the CFLAGS, using it as an indicator that the developer does not want to debug in GDB anyway. Signed-off-by: İsmail Dönmez <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 9537d1c commit 969563c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

config.mak.uname

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,12 @@ else
574574
ifneq ($(shell expr "$(uname_R)" : '1\.'),2)
575575
# MSys2
576576
prefix = /usr/
577+
# Enable DEP
578+
BASIC_LDFLAGS += -Wl,--nxcompat
579+
# Enable ASLR (unless debugging)
580+
ifneq (,$(findstring -O,$(CFLAGS)))
581+
BASIC_LDFLAGS += -Wl,--dynamicbase
582+
endif
577583
ifeq (MINGW32,$(MSYSTEM))
578584
prefix = /mingw32
579585
HOST_CPU = i686

0 commit comments

Comments
 (0)