Skip to content

Commit 978b576

Browse files
committed
Merge branch 'sg/filter-branch-dwim-ambiguity' into maint
Fix for a corner case in filter-branch. * sg/filter-branch-dwim-ambiguity: filter-branch: deal with object name vs. pathname ambiguity in tree-filter
2 parents 2cc3640 + 4d2a364 commit 978b576

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

git-filter-branch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ while read commit parents; do
319319
die "tree filter failed: $filter_tree"
320320

321321
(
322-
git diff-index -r --name-only --ignore-submodules $commit &&
322+
git diff-index -r --name-only --ignore-submodules $commit -- &&
323323
git ls-files --others
324324
) > "$tempdir"/tree-state || exit
325325
git update-index --add --replace --remove --stdin \

t/t7003-filter-branch.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,4 +418,11 @@ test_expect_success 'filter commit message without trailing newline' '
418418
test_cmp expect actual
419419
'
420420

421+
test_expect_success 'tree-filter deals with object name vs pathname ambiguity' '
422+
test_when_finished "git reset --hard original" &&
423+
ambiguous=$(git rev-list -1 HEAD) &&
424+
git filter-branch --tree-filter "mv file.t $ambiguous" HEAD^.. &&
425+
git show HEAD:$ambiguous
426+
'
427+
421428
test_done

0 commit comments

Comments
 (0)