Merge branch 'jc/string-list-cleanup' into seen

gitster · gitster · commit 9dde6693b088 · 2022-07-23T11:28:29.000-07:00
Code clean-up.

* jc/string-list-cleanup:
  builtin/remote.c: use the right kind of STRING_LIST_INIT
diff --git a/builtin/remote.c b/builtin/remote.c
@@ -1229,10 +1229,9 @@ static int get_one_entry(struct remote *remote, void *priv)
 
 static int show_all(void)
 {
-	struct string_list list = STRING_LIST_INIT_NODUP;
+	struct string_list list = STRING_LIST_INIT_DUP;
 	int result;
 
-	list.strdup_strings = 1;
 	result = for_each_remote(get_one_entry, &list);
 
 	if (!result) {

Original file line number	Diff line number	Diff line change
`@@ -1229,10 +1229,9 @@ static int get_one_entry(struct remote remote, void priv)`
`1229`	`1229`
`1230`	`1230`	`static int show_all(void)`
`1231`	`1231`	`{`
`1232`		`- struct string_list list = STRING_LIST_INIT_NODUP;`
	`1232`	`+ struct string_list list = STRING_LIST_INIT_DUP;`
`1233`	`1233`	`int result;`
`1234`	`1234`
`1235`		`- list.strdup_strings = 1;`
`1236`	`1235`	`result = for_each_remote(get_one_entry, &list);`
`1237`	`1236`
`1238`	`1237`	`if (!result) {`