Skip to content

Commit 9e6b28d

Browse files
arobendscho
authored andcommitted
Fix launching of externals from Unicode paths
If Git were installed in a path containing non-ASCII characters, commands such as git-am and git-submodule, which are implemented as externals, would fail to launch with the following error: > fatal: 'am' appears to be a git command, but we were not > able to execute it. Maybe git-am is broken? This was due to lookup_prog not being Unicode-aware. It was somehow missed in 2ee5a1a. Note that the only problem in this function was calling GetFileAttributes instead of GetFileAttributesW. The calls to access() were fine because access() is a macro which resolves to mingw_access, which already handles Unicode correctly. But I changed lookup_prog to use _waccess directly so that we only convert the path to UTF-16 once. Signed-off-by: Adam Roben <[email protected]>
1 parent d44acf7 commit 9e6b28d

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

compat/mingw.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,14 +1161,20 @@ static char *lookup_prog(const char *dir, int dirlen, const char *cmd,
11611161
int isexe, int exe_only)
11621162
{
11631163
char path[MAX_PATH];
1164+
wchar_t wpath[MAX_PATH];
11641165
snprintf(path, sizeof(path), "%.*s\\%s.exe", dirlen, dir, cmd);
11651166

1166-
if (!isexe && access(path, F_OK) == 0)
1167+
if (xutftowcs_path(wpath, path) < 0)
1168+
return NULL;
1169+
1170+
if (!isexe && _waccess(wpath, F_OK) == 0)
11671171
return xstrdup(path);
11681172
path[strlen(path)-4] = '\0';
1169-
if ((!exe_only || isexe) && access(path, F_OK) == 0)
1170-
if (!(GetFileAttributes(path) & FILE_ATTRIBUTE_DIRECTORY))
1173+
if ((!exe_only || isexe) && _waccess(wpath, F_OK) == 0) {
1174+
1175+
if (!(GetFileAttributesW(wpath) & FILE_ATTRIBUTE_DIRECTORY))
11711176
return xstrdup(path);
1177+
}
11721178
return NULL;
11731179
}
11741180

0 commit comments

Comments
 (0)