Skip to content

Commit a2d252d

Browse files
dschoGit for Windows Build Agent
authored andcommitted
drop! Merge branch 'fsmonitor4' of https://github.com/jeffhostetler/git
Drop v1 of the patch series in preparation for merging v2. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent fa58fa7 commit a2d252d

26 files changed

+23
-3839
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@
7272
/git-format-patch
7373
/git-fsck
7474
/git-fsck-objects
75-
/git-fsmonitor--daemon
7675
/git-gc
7776
/git-get-tar-commit-id
7877
/git-grep

Documentation/config/core.txt

Lines changed: 10 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -66,43 +66,18 @@ core.fsmonitor::
6666
will identify all files that may have changed since the
6767
requested date/time. This information is used to speed up git by
6868
avoiding unnecessary processing of files that have not changed.
69-
+
70-
See the "fsmonitor-watchman" section of linkgit:githooks[5].
71-
+
72-
Note: FSMonitor hooks (and this config setting) are ignored if the
73-
built-in FSMonitor is enabled (see `core.useBuiltinFSMonitor`).
69+
See the "fsmonitor-watchman" section of linkgit:githooks[5].
7470

7571
core.fsmonitorHookVersion::
76-
Sets the version of hook that is to be used when calling the
77-
FSMonitor hook (as configured via `core.fsmonitor`).
78-
+
79-
There are currently versions 1 and 2. When this is not set,
80-
version 2 will be tried first and if it fails then version 1
81-
will be tried. Version 1 uses a timestamp as input to determine
82-
which files have changes since that time but some monitors
83-
like watchman have race conditions when used with a timestamp.
84-
Version 2 uses an opaque string so that the monitor can return
85-
something that can be used to determine what files have changed
86-
without race conditions.
87-
+
88-
Note: FSMonitor hooks (and this config setting) are ignored if the
89-
built-in FSMonitor is enabled (see `core.useBuiltinFSMonitor`).
90-
91-
core.useBuiltinFSMonitor::
92-
If set to true, enable the built-in filesystem event watcher (for
93-
technical details, see linkgit:git-fsmonitor--daemon[1]).
94-
+
95-
Like external (hook-based) FSMonitors, the built-in FSMonitor can speed up
96-
Git commands that need to refresh the Git index (e.g. `git status`) in a
97-
worktree with many files. The built-in FSMonitor facility eliminates the
98-
need to install and maintain an external third-party monitoring tool.
99-
+
100-
The built-in FSMonitor is currently available only on a limited set of
101-
supported platforms.
102-
+
103-
Note: if this config setting is set to `true`, any FSMonitor hook
104-
configured via `core.fsmonitor` (and possibly `core.fsmonitorHookVersion`)
105-
is ignored.
72+
Sets the version of hook that is to be used when calling fsmonitor.
73+
There are currently versions 1 and 2. When this is not set,
74+
version 2 will be tried first and if it fails then version 1
75+
will be tried. Version 1 uses a timestamp as input to determine
76+
which files have changes since that time but some monitors
77+
like watchman have race conditions when used with a timestamp.
78+
Version 2 uses an opaque string so that the monitor can return
79+
something that can be used to determine what files have changed
80+
without race conditions.
10681

10782
core.trustctime::
10883
If false, the ctime differences between the index and the

Documentation/git-fsmonitor--daemon.txt

Lines changed: 0 additions & 104 deletions
This file was deleted.

Documentation/git-update-index.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,7 @@ FILE SYSTEM MONITOR
498498
This feature is intended to speed up git operations for repos that have
499499
large working directories.
500500

501-
It enables git to work together with a file system monitor (see
502-
linkgit:git-fsmonitor--daemon[1]
503-
and the
501+
It enables git to work together with a file system monitor (see the
504502
"fsmonitor-watchman" section of linkgit:githooks[5]) that can
505503
inform it as to what files have been modified. This enables git to avoid
506504
having to lstat() every file to find modified files.

Documentation/githooks.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -593,8 +593,7 @@ fsmonitor-watchman
593593

594594
This hook is invoked when the configuration option `core.fsmonitor` is
595595
set to `.git/hooks/fsmonitor-watchman` or `.git/hooks/fsmonitor-watchmanv2`
596-
depending on the version of the hook to use, unless overridden via
597-
`core.useBuiltinFSMonitor` (see linkgit:git-config[1]).
596+
depending on the version of the hook to use.
598597

599598
Version 1 takes two arguments, a version (1) and the time in elapsed
600599
nanoseconds since midnight, January 1, 1970.

Makefile

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -467,11 +467,6 @@ all::
467467
# directory, and the JSON compilation database 'compile_commands.json' will be
468468
# created at the root of the repository.
469469
#
470-
# If your platform supports an built-in fsmonitor backend, set
471-
# FSMONITOR_DAEMON_BACKEND to the name of the corresponding
472-
# `compat/fsmonitor/fsmonitor-fs-listen-<name>.c` that implements the
473-
# `fsmonitor_fs_listen__*()` routines.
474-
#
475470
# Define DEVELOPER to enable more compiler warnings. Compiler version
476471
# and family are auto detected, but could be overridden by defining
477472
# COMPILER_FEATURES (see config.mak.dev). You can still set
@@ -898,7 +893,6 @@ LIB_OBJS += fetch-pack.o
898893
LIB_OBJS += fmt-merge-msg.o
899894
LIB_OBJS += fsck.o
900895
LIB_OBJS += fsmonitor.o
901-
LIB_OBJS += fsmonitor-ipc.o
902896
LIB_OBJS += gettext.o
903897
LIB_OBJS += gpg-interface.o
904898
LIB_OBJS += graph.o
@@ -1102,7 +1096,6 @@ BUILTIN_OBJS += builtin/fmt-merge-msg.o
11021096
BUILTIN_OBJS += builtin/for-each-ref.o
11031097
BUILTIN_OBJS += builtin/for-each-repo.o
11041098
BUILTIN_OBJS += builtin/fsck.o
1105-
BUILTIN_OBJS += builtin/fsmonitor--daemon.o
11061099
BUILTIN_OBJS += builtin/gc.o
11071100
BUILTIN_OBJS += builtin/get-tar-commit-id.o
11081101
BUILTIN_OBJS += builtin/grep.o
@@ -1933,11 +1926,6 @@ ifdef NEED_ACCESS_ROOT_HANDLER
19331926
COMPAT_OBJS += compat/access.o
19341927
endif
19351928

1936-
ifdef FSMONITOR_DAEMON_BACKEND
1937-
COMPAT_CFLAGS += -DHAVE_FSMONITOR_DAEMON_BACKEND
1938-
COMPAT_OBJS += compat/fsmonitor/fsmonitor-fs-listen-$(FSMONITOR_DAEMON_BACKEND).o
1939-
endif
1940-
19411929
ifeq ($(TCLTK_PATH),)
19421930
NO_TCLTK = NoThanks
19431931
endif
@@ -2802,9 +2790,6 @@ GIT-BUILD-OPTIONS: FORCE
28022790
@echo PAGER_ENV=\''$(subst ','\'',$(subst ','\'',$(PAGER_ENV)))'\' >>$@+
28032791
@echo DC_SHA1=\''$(subst ','\'',$(subst ','\'',$(DC_SHA1)))'\' >>$@+
28042792
@echo X=\'$(X)\' >>$@+
2805-
ifdef FSMONITOR_DAEMON_BACKEND
2806-
@echo FSMONITOR_DAEMON_BACKEND=\''$(subst ','\'',$(subst ','\'',$(FSMONITOR_DAEMON_BACKEND)))'\' >>$@+
2807-
endif
28082793
ifdef TEST_OUTPUT_DIRECTORY
28092794
@echo TEST_OUTPUT_DIRECTORY=\''$(subst ','\'',$(subst ','\'',$(TEST_OUTPUT_DIRECTORY)))'\' >>$@+
28102795
endif

builtin.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix);
159159
int cmd_for_each_repo(int argc, const char **argv, const char *prefix);
160160
int cmd_format_patch(int argc, const char **argv, const char *prefix);
161161
int cmd_fsck(int argc, const char **argv, const char *prefix);
162-
int cmd_fsmonitor__daemon(int argc, const char **argv, const char *prefix);
163162
int cmd_gc(int argc, const char **argv, const char *prefix);
164163
int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix);
165164
int cmd_grep(int argc, const char **argv, const char *prefix);

0 commit comments

Comments
 (0)