Skip to content

Commit a894849

Browse files
committed
mingw: use domain information for default email
When a user is registered in a Windows domain, it is really easy to obtain the email address. So let's do that. Suggested by Lutz Roeder. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 96f58de commit a894849

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

compat/mingw.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1959,6 +1959,11 @@ static char *get_extended_user_info(enum EXTENDED_NAME_FORMAT type)
19591959
return NULL;
19601960
}
19611961

1962+
char *mingw_query_user_email(void)
1963+
{
1964+
return get_extended_user_info(NameUserPrincipal);
1965+
}
1966+
19621967
struct passwd *getpwuid(int uid)
19631968
{
19641969
static unsigned initialized;

compat/mingw.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,8 @@ int mingw_offset_1st_component(const char *path);
433433
#define PATH_SEP ';'
434434
extern const char *program_data_config(void);
435435
#define git_program_data_config program_data_config
436+
extern char *mingw_query_user_email(void);
437+
#define query_user_email mingw_query_user_email
436438
#ifndef __MINGW64_VERSION_MAJOR
437439
#define PRIuMAX "I64u"
438440
#define PRId64 "I64d"

git-compat-util.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,10 @@ static inline char *git_find_last_dir_sep(const char *path)
373373
#define git_program_data_config() NULL
374374
#endif
375375

376+
#ifndef query_user_email
377+
#define query_user_email() NULL
378+
#endif
379+
376380
#if defined(__HP_cc) && (__HP_cc >= 61000)
377381
#define NORETURN __attribute__((noreturn))
378382
#define NORETURN_PTR

ident.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,9 @@ const char *ident_default_email(void)
168168
strbuf_addstr(&git_default_email, email);
169169
committer_ident_explicitly_given |= IDENT_MAIL_GIVEN;
170170
author_ident_explicitly_given |= IDENT_MAIL_GIVEN;
171-
} else
171+
} else if ((email = query_user_email()) && email[0])
172+
strbuf_addstr(&git_default_email, email);
173+
else
172174
copy_email(xgetpwuid_self(&default_email_is_bogus),
173175
&git_default_email, &default_email_is_bogus);
174176
strbuf_trim(&git_default_email);

0 commit comments

Comments
 (0)