Skip to content

Commit afea77a

Browse files
PhilipOakleygitster
authored andcommitted
rebase: note preserve merges may be a pull config option
The `--preserve-merges` option was removed by v2.34.0. However users may not be aware that it is also a Pull configuration option, which is still offered by major IDE vendors such as Visual Studio. Extend the `--preserve-merges` die message to also direct users to the possible use of the `preserve` option in the `pull.rebase` config. This is an additional 'belt and braces' information statement. Signed-off-by: Philip Oakley <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent afd58a0 commit afea77a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

builtin/rebase.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,9 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
12071207
builtin_rebase_usage, 0);
12081208

12091209
if (preserve_merges_selected)
1210-
die(_("--preserve-merges was replaced by --rebase-merges"));
1210+
die(_("--preserve-merges was replaced by --rebase-merges\n"
1211+
"Note: Your `pull.rebase` configuration may also be set to 'preserve',\n"
1212+
"which is no longer supported; use 'merges' instead"));
12111213

12121214
if (action != ACTION_NONE && total_argc != 2) {
12131215
usage_with_options(builtin_rebase_usage,

0 commit comments

Comments
 (0)