Skip to content

Commit b352891

Browse files
devzero2000gitster
authored andcommitted
git-tag.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent fb6644a commit b352891

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/examples/git-tag.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ prev=0000000000000000000000000000000000000000
156156
if git show-ref --verify --quiet -- "refs/tags/$name"
157157
then
158158
test -n "$force" || die "tag '$name' already exists"
159-
prev=`git rev-parse "refs/tags/$name"`
159+
prev=$(git rev-parse "refs/tags/$name")
160160
fi
161161
shift
162162
git check-ref-format "tags/$name" ||

0 commit comments

Comments
 (0)