Skip to content

Commit b6bd2d0

Browse files
committed
Merge branch 'bn/send-email-smtp-auth-error-message-fix'
Fix a minor regression brought in to "git send-email" by a recent addition of the "--smtp-auth" option. * bn/send-email-smtp-auth-error-message-fix: send-email: fix uninitialized var warning for $smtp_auth
2 parents e646ab9 + 904f6e7 commit b6bd2d0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-send-email.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1136,7 +1136,7 @@ sub smtp_auth_maybe {
11361136

11371137
# Check mechanism naming as defined in:
11381138
# https://tools.ietf.org/html/rfc4422#page-8
1139-
if ($smtp_auth !~ /^(\b[A-Z0-9-_]{1,20}\s*)*$/) {
1139+
if ($smtp_auth && $smtp_auth !~ /^(\b[A-Z0-9-_]{1,20}\s*)*$/) {
11401140
die "invalid smtp auth: '${smtp_auth}'";
11411141
}
11421142

0 commit comments

Comments
 (0)