Skip to content

Commit b712e3e

Browse files
glandiumdscho
authored andcommitted
clone: call transport_set_verbosity before anything else on the newly created transport
Commit 2879bc3 made the progress and verbosity options sent to remote helper earlier than they previously were. But nothing else after that would send updates if the value is changed later on with transport_set_verbosity. While for fetch and push, transport_set_verbosity is the first thing that is done after creating the transport, it was not the case for clone. So commit 2879bc3 broke changing progress and verbosity for clone, for urls requiring a remote helper only (so, not git:// urls, for instance). Moving transport_set_verbosity to just after the transport is created works around the issue. This fixes #158 Signed-off-by: Mike Hommey <[email protected]> Signed-off-by: Junio C Hamano <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 49b9363 commit b712e3e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

builtin/clone.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -906,6 +906,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
906906

907907
remote = remote_get(option_origin);
908908
transport = transport_get(remote, remote->url[0]);
909+
transport_set_verbosity(transport, option_verbosity, option_progress);
910+
909911
path = get_repo_path(remote->url[0], &is_bundle);
910912
is_local = option_local != 0 && path && !is_bundle;
911913
if (is_local) {
@@ -932,8 +934,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
932934
if (option_single_branch)
933935
transport_set_option(transport, TRANS_OPT_FOLLOWTAGS, "1");
934936

935-
transport_set_verbosity(transport, option_verbosity, option_progress);
936-
937937
if (option_upload_pack)
938938
transport_set_option(transport, TRANS_OPT_UPLOADPACK,
939939
option_upload_pack);

0 commit comments

Comments
 (0)