Skip to content

Commit b865734

Browse files
j6tgitster
authored andcommitted
replace "parameters" by "arguments" in error messages
When an error message informs the user about an incorrect command invocation, it should refer to "arguments", not "parameters". Signed-off-by: Johannes Sixt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 59ec224 commit b865734

File tree

6 files changed

+18
-18
lines changed

6 files changed

+18
-18
lines changed

bisect.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1064,7 +1064,7 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
10641064

10651065
if (!all) {
10661066
fprintf(stderr, _("No testable commit found.\n"
1067-
"Maybe you started with bad path parameters?\n"));
1067+
"Maybe you started with bad path arguments?\n"));
10681068

10691069
return BISECT_NO_TESTABLE_COMMIT;
10701070
}

builtin/notes.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ static int list(int argc, const char **argv, const char *prefix)
373373
git_notes_list_usage, 0);
374374

375375
if (1 < argc) {
376-
error(_("too many parameters"));
376+
error(_("too many arguments"));
377377
usage_with_options(git_notes_list_usage, options);
378378
}
379379

@@ -428,7 +428,7 @@ static int add(int argc, const char **argv, const char *prefix)
428428
PARSE_OPT_KEEP_ARGV0);
429429

430430
if (2 < argc) {
431-
error(_("too many parameters"));
431+
error(_("too many arguments"));
432432
usage_with_options(git_notes_add_usage, options);
433433
}
434434

@@ -506,19 +506,19 @@ static int copy(int argc, const char **argv, const char *prefix)
506506

507507
if (from_stdin || rewrite_cmd) {
508508
if (argc) {
509-
error(_("too many parameters"));
509+
error(_("too many arguments"));
510510
usage_with_options(git_notes_copy_usage, options);
511511
} else {
512512
return notes_copy_from_stdin(force, rewrite_cmd);
513513
}
514514
}
515515

516516
if (argc < 1) {
517-
error(_("too few parameters"));
517+
error(_("too few arguments"));
518518
usage_with_options(git_notes_copy_usage, options);
519519
}
520520
if (2 < argc) {
521-
error(_("too many parameters"));
521+
error(_("too many arguments"));
522522
usage_with_options(git_notes_copy_usage, options);
523523
}
524524

@@ -595,7 +595,7 @@ static int append_edit(int argc, const char **argv, const char *prefix)
595595
PARSE_OPT_KEEP_ARGV0);
596596

597597
if (2 < argc) {
598-
error(_("too many parameters"));
598+
error(_("too many arguments"));
599599
usage_with_options(usage, options);
600600
}
601601

@@ -662,7 +662,7 @@ static int show(int argc, const char **argv, const char *prefix)
662662
0);
663663

664664
if (1 < argc) {
665-
error(_("too many parameters"));
665+
error(_("too many arguments"));
666666
usage_with_options(git_notes_show_usage, options);
667667
}
668668

@@ -812,7 +812,7 @@ static int merge(int argc, const char **argv, const char *prefix)
812812
error(_("must specify a notes ref to merge"));
813813
usage_with_options(git_notes_merge_usage, options);
814814
} else if (!do_merge && argc) {
815-
error(_("too many parameters"));
815+
error(_("too many arguments"));
816816
usage_with_options(git_notes_merge_usage, options);
817817
}
818818

@@ -960,7 +960,7 @@ static int prune(int argc, const char **argv, const char *prefix)
960960
0);
961961

962962
if (argc) {
963-
error(_("too many parameters"));
963+
error(_("too many arguments"));
964964
usage_with_options(git_notes_prune_usage, options);
965965
}
966966

@@ -982,7 +982,7 @@ static int get_ref(int argc, const char **argv, const char *prefix)
982982
git_notes_get_ref_usage, 0);
983983

984984
if (argc) {
985-
error(_("too many parameters"));
985+
error(_("too many arguments"));
986986
usage_with_options(git_notes_get_ref_usage, options);
987987
}
988988

builtin/stash.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ static int clear_stash(int argc, const char **argv, const char *prefix)
222222
PARSE_OPT_STOP_AT_NON_OPTION);
223223

224224
if (argc)
225-
return error(_("git stash clear with parameters is "
225+
return error(_("git stash clear with arguments is "
226226
"unimplemented"));
227227

228228
return do_clear_stash();

builtin/tag.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
540540

541541
object_ref = argc == 2 ? argv[1] : "HEAD";
542542
if (argc > 2)
543-
die(_("too many params"));
543+
die(_("too many arguments"));
544544

545545
if (get_oid(object_ref, &object))
546546
die(_("Failed to resolve '%s' as a valid ref."), object_ref);

t/t3301-notes.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1293,11 +1293,11 @@ test_expect_success 'GIT_NOTES_REWRITE_REF overrides config' '
12931293
grep "replacement note 3" actual
12941294
'
12951295

1296-
test_expect_success 'git notes copy diagnoses too many or too few parameters' '
1296+
test_expect_success 'git notes copy diagnoses too many or too few arguments' '
12971297
test_must_fail git notes copy 2>error &&
1298-
test_i18ngrep "too few parameters" error &&
1298+
test_i18ngrep "too few arguments" error &&
12991299
test_must_fail git notes copy one two three 2>error &&
1300-
test_i18ngrep "too many parameters" error
1300+
test_i18ngrep "too many arguments" error
13011301
'
13021302

13031303
test_expect_success 'git notes get-ref expands refs/heads/master to refs/notes/refs/heads/master' '

t/t6030-bisect-porcelain.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,9 +575,9 @@ test_expect_success 'skipping away from skipped commit' '
575575
test "$para3" = "$PARA_HASH3"
576576
'
577577

578-
test_expect_success 'erroring out when using bad path parameters' '
578+
test_expect_success 'erroring out when using bad path arguments' '
579579
test_must_fail git bisect start $PARA_HASH7 $HASH1 -- foobar 2> error.txt &&
580-
test_i18ngrep "bad path parameters" error.txt
580+
test_i18ngrep "bad path arguments" error.txt
581581
'
582582

583583
test_expect_success 'test bisection on bare repo - --no-checkout specified' '

0 commit comments

Comments
 (0)