Skip to content

Commit bad7910

Browse files
rscharfegitster
authored andcommitted
reftable: release name on reftable_reader_new() error
If block_source_read_block() or parse_footer() fail, we leak the "name" member of struct reftable_reader in reftable_reader_new(). Release it. Reported by: H Z <[email protected]> Helped-by: Jeff King <[email protected]> Signed-off-by: René Scharfe <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent cb0ae67 commit bad7910

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

reftable/reader.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -666,6 +666,8 @@ int reftable_reader_new(struct reftable_reader **out,
666666
reftable_block_done(&footer);
667667
reftable_block_done(&header);
668668
if (err) {
669+
if (r)
670+
reftable_free(r->name);
669671
reftable_free(r);
670672
block_source_close(source);
671673
}

0 commit comments

Comments
 (0)