Skip to content

Commit bb6906b

Browse files
ismaildscho
authored andcommitted
Enable DEP and ASLR
Enable DEP (Data Execution Prevention) and ASLR (Address Space Layout Randomization) support. This applies to both 32bit and 64bit builds and makes it substantially harder to exploit security holes in Git by offering a much more unpredictable attack surface. ASLR interferes with GDB's ability to set breakpoints. A similar issue holds true when compiling with -O2 (in which case single-stepping is messed up because GDB cannot map the code back to the original source code properly). Therefore we simply enable ASLR only when an optimization flag is present in the CFLAGS, using it as an indicator that the developer does not want to debug in GDB anyway. Signed-off-by: İsmail Dönmez <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 62db56f commit bb6906b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

config.mak.uname

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -571,6 +571,12 @@ else
571571
ifneq ($(shell expr "$(uname_R)" : '1\.'),2)
572572
# MSys2
573573
prefix = /usr/
574+
# Enable DEP
575+
BASIC_LDFLAGS += -Wl,--nxcompat
576+
# Enable ASLR (unless debugging)
577+
ifneq (,$(findstring -O,$(CFLAGS)))
578+
BASIC_LDFLAGS += -Wl,--dynamicbase
579+
endif
574580
ifeq (MINGW32,$(MSYSTEM))
575581
prefix = /mingw32
576582
HOST_CPU = i686

0 commit comments

Comments
 (0)