Skip to content

Commit bd368a9

Browse files
devzero2000gitster
authored andcommitted
t9362-mw-to-git-utf8.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent c9b9270 commit bd368a9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

contrib/mw-to-git/t/t9362-mw-to-git-utf8.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ test_expect_success 'The shallow option works with accents' '
7070
test_path_is_file mw_dir_4/Main_Page.mw &&
7171
(
7272
cd mw_dir_4 &&
73-
test `git log --oneline Néoà.mw | wc -l` -eq 1 &&
74-
test `git log --oneline Main_Page.mw | wc -l ` -eq 1
73+
test $(git log --oneline Néoà.mw | wc -l) -eq 1 &&
74+
test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
7575
) &&
7676
wiki_check_content mw_dir_4/Néoà.mw Néoà &&
7777
wiki_check_content mw_dir_4/Main_Page.mw Main_Page

0 commit comments

Comments
 (0)