Skip to content

Commit c13ee8c

Browse files
kbleesGit for Windows Build Agent
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent f848e24 commit c13ee8c

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw-posix.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ struct utsname {
120120
* trivial stubs
121121
*/
122122

123-
static inline int symlink(const char *oldpath UNUSED, const char *newpath UNUSED)
124-
{ errno = ENOSYS; return -1; }
125123
static inline int fchmod(int fildes UNUSED, mode_t mode UNUSED)
126124
{ errno = ENOSYS; return -1; }
127125
#ifndef __MINGW64_VERSION_MAJOR
@@ -194,6 +192,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
194192
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
195193
int link(const char *oldpath, const char *newpath);
196194
int uname(struct utsname *buf);
195+
int symlink(const char *target, const char *link);
197196
int readlink(const char *path, char *buf, size_t bufsiz);
198197

199198
/*

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2967,6 +2967,34 @@ int link(const char *oldpath, const char *newpath)
29672967
return 0;
29682968
}
29692969

2970+
int symlink(const char *target, const char *link)
2971+
{
2972+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2973+
int len;
2974+
2975+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2976+
if (!has_symlinks) {
2977+
errno = ENOSYS;
2978+
return -1;
2979+
}
2980+
2981+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2982+
|| xutftowcs_long_path(wlink, link) < 0)
2983+
return -1;
2984+
2985+
/* convert target dir separators to backslashes */
2986+
while (len--)
2987+
if (wtarget[len] == '/')
2988+
wtarget[len] = '\\';
2989+
2990+
/* create file symlink */
2991+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2992+
errno = err_win_to_posix(GetLastError());
2993+
return -1;
2994+
}
2995+
return 0;
2996+
}
2997+
29702998
#ifndef _WINNT_H
29712999
/*
29723000
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

0 commit comments

Comments
 (0)