Skip to content

Commit c66631d

Browse files
brad0gitster
authored andcommitted
config.mak.uname: update settings for FreeBSD
Even though FreeBSD 6 introduced memmem(), the implementation in that version was buggy and not performant until FreeBSD 12, FreeBSD 11.4 (the last version of FreeBSD 11) went end of life in September 2021, so nobody should be using it since it hasn't had security support since then. And memmem() has even been functional (but slow) since FreeBSD 11.0, and 10.4 went EOL in 2018. So users shouldn't actually be experiencing any actual functionality problems since then. Let's draw the line to require FreeBSD 12 or newer (but we do not officially document it or enforce it by breaking build when compiled on older versions, at least not yet), which allows us to drop the special casing of FreeBSD 4.x and rely on platform implementation of memmem() unconditionally. Signed-off-by: Brad Smith <[email protected]> [jc: log message with help from info by brian carlson] Reviewed-by: Collin Funk <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d50a5e8 commit c66631d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

config.mak.uname

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -273,16 +273,10 @@ ifeq ($(uname_S),FreeBSD)
273273
ifeq ($(firstword $(subst -, ,$(uname_R))),10.1)
274274
OLD_ICONV = YesPlease
275275
endif
276-
NO_MEMMEM = YesPlease
277276
BASIC_CFLAGS += -I/usr/local/include
278277
BASIC_LDFLAGS += -L/usr/local/lib
279278
DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
280279
USE_ST_TIMESPEC = YesPlease
281-
ifeq ($(shell expr "$(uname_R)" : '4\.'),2)
282-
PTHREAD_LIBS = -pthread
283-
NO_UINTMAX_T = YesPlease
284-
NO_STRTOUMAX = YesPlease
285-
endif
286280
PYTHON_PATH = /usr/local/bin/python
287281
PERL_PATH = /usr/local/bin/perl
288282
HAVE_PATHS_H = YesPlease

0 commit comments

Comments
 (0)