Skip to content

Commit cc7e816

Browse files
Antonio Ospitegitster
authored andcommitted
t/t9001-send-email.sh: fix '&&' chain in some tests
t/README recommends chaining test assertions. Signed-off-by: Antonio Ospite <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent db54c8e commit cc7e816

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

t/t9001-send-email.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ test_expect_success $PREREQ 'Author From: in message body' '
265265
266266
--smtp-server="$(pwd)/fake.sendmail" \
267267
$patches &&
268-
sed "1,/^\$/d" < msgtxt1 > msgbody1
268+
sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
269269
grep "From: A <[email protected]>" msgbody1
270270
'
271271

@@ -276,7 +276,7 @@ test_expect_success $PREREQ 'Author From: not in message body' '
276276
277277
--smtp-server="$(pwd)/fake.sendmail" \
278278
$patches &&
279-
sed "1,/^\$/d" < msgtxt1 > msgbody1
279+
sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
280280
! grep "From: A <[email protected]>" msgbody1
281281
'
282282

@@ -298,7 +298,7 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '
298298
--in-reply-to=" " \
299299
--smtp-server="$(pwd)/fake.sendmail" \
300300
$patches \
301-
2>errors
301+
2>errors &&
302302
! grep "^In-Reply-To: < *>" msgtxt1
303303
'
304304

@@ -617,7 +617,7 @@ EOF
617617
"
618618

619619
test_expect_success $PREREQ '--suppress-cc=sob' '
620-
git config --unset sendemail.cccmd
620+
test_might_fail git config --unset sendemail.cccmd &&
621621
test_suppression sob
622622
'
623623

0 commit comments

Comments
 (0)