Skip to content

Commit cdba233

Browse files
dschogitster
authored andcommitted
bisect: remove Cogito-related code
Once upon a time, there was this idea that Git would not actually be a single coherent program, but rather a set of low-level programs that users cobble together via shell scripts, or develop high-level user interfaces for Git, or both. Cogito was such a high-level user interface, incidentally implemented via shell scripts that cobble together Git calls. It did turn out relatively quickly that Git would much rather provide a useful high-level user interface itself. As of April 19th, 2007, Cogito was therefore discontinued (see https://lore.kernel.org/git/[email protected]/). Nevertheless, for almost 15 years after that announcement, Git carried special code in `git bisect` to accommodate Cogito. Since it is beyond doubt that there are no more Cogito users, let's remove the last remnant of Cogito-accommodating code. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6e08040 commit cdba233

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

builtin/bisect.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ static GIT_PATH_FUNC(git_path_bisect_expected_rev, "BISECT_EXPECTED_REV")
1414
static GIT_PATH_FUNC(git_path_bisect_ancestors_ok, "BISECT_ANCESTORS_OK")
1515
static GIT_PATH_FUNC(git_path_bisect_start, "BISECT_START")
1616
static GIT_PATH_FUNC(git_path_bisect_log, "BISECT_LOG")
17-
static GIT_PATH_FUNC(git_path_head_name, "head-name")
1817
static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES")
1918
static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
2019
static GIT_PATH_FUNC(git_path_bisect_run, "BISECT_RUN")
@@ -808,13 +807,6 @@ static enum bisect_error bisect_start(struct bisect_terms *terms, const char **a
808807
strbuf_addstr(&start_head, oid_to_hex(&head_oid));
809808
} else if (!get_oid(head, &head_oid) &&
810809
skip_prefix(head, "refs/heads/", &head)) {
811-
/*
812-
* This error message should only be triggered by
813-
* cogito usage, and cogito users should understand
814-
* it relates to cg-seek.
815-
*/
816-
if (!is_empty_or_missing_file(git_path_head_name()))
817-
return error(_("won't bisect on cg-seek'ed tree"));
818810
strbuf_addstr(&start_head, head);
819811
} else {
820812
return error(_("bad HEAD - strange symbolic ref"));

0 commit comments

Comments
 (0)