Skip to content

Commit cf3ae2f

Browse files
committed
mingw (git_terminal_prompt): do fall back to CONIN$/CONOUT$ method
To support Git Bash running in a MinTTY, we use a dirty trick to access the MSYS2 pseudo terminal: we execute a Bash snippet that accesses /dev/tty. The idea was to fall back to writing to/reading from CONOUT$/CONIN$ if that Bash call failed because Bash was not found. However, we should fall back even in other error conditions, because we have not successfully read the user input. Let's make it so. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 5bd1a20 commit cf3ae2f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compat/terminal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ char *git_terminal_prompt(const char *prompt, int echo)
161161

162162
/* try shell_prompt first, fall back to CONIN/OUT if bash is missing */
163163
char *result = shell_prompt(prompt, echo);
164-
if (result || errno != ENOENT)
164+
if (result)
165165
return result;
166166

167167
#endif

0 commit comments

Comments
 (0)