Skip to content

Commit d16df0c

Browse files
ralfthgitster
authored andcommitted
string_list: use string-list API in unsorted_string_list_lookup()
Using the string-list API in function unsorted_string_list_lookup() makes the code more readable. Signed-off-by: Ralf Thielow <[email protected]> Acked-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6a66362 commit d16df0c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

string-list.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,12 @@ void string_list_sort(struct string_list *list)
231231
struct string_list_item *unsorted_string_list_lookup(struct string_list *list,
232232
const char *string)
233233
{
234-
int i;
234+
struct string_list_item *item;
235235
compare_strings_fn cmp = list->cmp ? list->cmp : strcmp;
236236

237-
for (i = 0; i < list->nr; i++)
238-
if (!cmp(string, list->items[i].string))
239-
return list->items + i;
237+
for_each_string_list_item(item, list)
238+
if (!cmp(string, item->string))
239+
return item;
240240
return NULL;
241241
}
242242

0 commit comments

Comments
 (0)