Skip to content

Commit d22e567

Browse files
jrngitster
authored andcommitted
perl/Makefile.PL: warn about duplicate module list in perl/Makefile
Adding or removing a module requires modifying both files to support builds with and without MakeMaker. Add a comment to remind patch authors and reviewers at the crucial moment. Longer term, it would be nicer to maintain a single list, perhaps in a separate file used by both build systems. Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 2ae48a9 commit d22e567

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

perl/Makefile.PL

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ endif
2424
MAKE_FRAG
2525
}
2626

27+
# XXX. When editing this list:
28+
#
29+
# * Please update perl/Makefile, too.
30+
# * Don't forget to test with NO_PERL_MAKEMAKER=YesPlease
2731
my %pm = (
2832
'Git.pm' => '$(INST_LIBDIR)/Git.pm',
2933
'Git/I18N.pm' => '$(INST_LIBDIR)/Git/I18N.pm',

0 commit comments

Comments
 (0)