Skip to content

Commit df7375d

Browse files
avargitster
authored andcommitted
CI: use shorter names that fit in UX tooltips
Change the names used for the GitHub CI workflows to be short enough to (mostly) fit in the pop-up tool-tips that GitHub shows in the commit view. I.e. when mouse-clicking on the passing or failing check-mark next to the commit subject. These names are seemingly truncated to 17-20 characters followed by three dots ("..."). Since a "CI/PR / " prefix is added to them the job names looked like this before (windows-test and vs-test jobs omitted): CI/PR / ci-config (p... CI/PR / windows-buil... CI/PR / vs-build (pu... CI/PR / regular (lin... CI/PR / regular (lin... CI/PR / regular (os... CI/PR / regular (os... CI/PR / regular (lin... CI/PR / regular (lin... CI/PR / dockerized (... CI/PR / dockerized (... CI/PR / dockerized (... CI/PR / static-anal... CI/PR / sparse (pu... CI/PR / documenta... By omitting the "/PR" from the top-level name, and pushing the $jobname to the front we'll now instead get: CI / config (push) CI / win build (push... CI / win+VS build (... CI / linux-clang (ub... CI / linux-gcc (ubun... CI / osx-clang (osx)... CI / osx-gcc (osx) (... CI / linux-gcc-defau... CI / linux-leaks (ub... CI / linux-musl (alp... CI / Linux32 (daald/... CI / pedantic (fedor... CI / static-analysis... CI / sparse (push)... CI / documentation We then have no truncation in the expanded view. See [1] for how it looked before, [2] for a currently visible CI run using this commit, and [3] for the GitHub workflow syntax involved being changed here. Let's also use the existing "pool" field as before. It's occasionally useful to know we're running on say ubuntu v.s. fedora. The "-latest" suffix is useful to some[4], and since it's now at the end it doesn't hurt readability in the short view compared to saying "ubuntu" or "macos". 1. https://github.com/git/git/tree/master/ 2. https://github.com/avar/git/tree/avar/ci-rm-travis-cleanup-ci-names-3 3. https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions 3. https://lore.kernel.org/git/[email protected]/ Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4a6e4b9 commit df7375d

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/workflows/main.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI/PR
1+
name: CI
22

33
on: [push, pull_request]
44

@@ -7,6 +7,7 @@ env:
77

88
jobs:
99
ci-config:
10+
name: config
1011
runs-on: ubuntu-latest
1112
outputs:
1213
enabled: ${{ steps.check-ref.outputs.enabled }}${{ steps.skip-if-redundant.outputs.enabled }}
@@ -77,6 +78,7 @@ jobs:
7778
}
7879
7980
windows-build:
81+
name: win build
8082
needs: ci-config
8183
if: needs.ci-config.outputs.enabled == 'yes'
8284
runs-on: windows-latest
@@ -97,6 +99,7 @@ jobs:
9799
name: windows-artifacts
98100
path: artifacts
99101
windows-test:
102+
name: win test
100103
runs-on: windows-latest
101104
needs: [windows-build]
102105
strategy:
@@ -127,6 +130,7 @@ jobs:
127130
name: failed-tests-windows
128131
path: ${{env.FAILED_TEST_ARTIFACTS}}
129132
vs-build:
133+
name: win+VS build
130134
needs: ci-config
131135
if: needs.ci-config.outputs.enabled == 'yes'
132136
env:
@@ -178,6 +182,7 @@ jobs:
178182
name: vs-artifacts
179183
path: artifacts
180184
vs-test:
185+
name: win+VS test
181186
runs-on: windows-latest
182187
needs: vs-build
183188
strategy:
@@ -210,6 +215,7 @@ jobs:
210215
name: failed-tests-windows
211216
path: ${{env.FAILED_TEST_ARTIFACTS}}
212217
regular:
218+
name: ${{matrix.vector.jobname}} (${{matrix.vector.pool}})
213219
needs: ci-config
214220
if: needs.ci-config.outputs.enabled == 'yes'
215221
strategy:
@@ -251,6 +257,7 @@ jobs:
251257
name: failed-tests-${{matrix.vector.jobname}}
252258
path: ${{env.FAILED_TEST_ARTIFACTS}}
253259
dockerized:
260+
name: ${{matrix.vector.jobname}} (${{matrix.vector.image}})
254261
needs: ci-config
255262
if: needs.ci-config.outputs.enabled == 'yes'
256263
strategy:
@@ -310,6 +317,7 @@ jobs:
310317
run: ci/install-dependencies.sh
311318
- run: make sparse
312319
documentation:
320+
name: documentation
313321
needs: ci-config
314322
if: needs.ci-config.outputs.enabled == 'yes'
315323
env:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![Build status](https://github.com/git/git/workflows/CI/PR/badge.svg)](https://github.com/git/git/actions?query=branch%3Amaster+event%3Apush)
1+
[![Build status](https://github.com/git/git/workflows/CI/badge.svg)](https://github.com/git/git/actions?query=branch%3Amaster+event%3Apush)
22

33
Git - fast, scalable, distributed revision control system
44
=========================================================

0 commit comments

Comments
 (0)