Skip to content

Commit e1c2eb5

Browse files
committed
Merge 'git-wrapper' into HEAD
Use msysGit's `git-wrapper` instead of the builtins. This works around two issues: - when the file system does not allow hard links, we would waste over 800 megabyte by having 109 copies of a multi-megabyte executable - even when the file system allows hard links, the Windows Explorer counts the disk usage as if it did not. Many users complained about Git for Windows using too much space (when it actually did not). We can easily avoid those user complaints by merging this branch. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents 3ffba4c + a62536d commit e1c2eb5

File tree

3 files changed

+533
-8
lines changed

3 files changed

+533
-8
lines changed

Makefile

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1678,11 +1678,17 @@ version.sp version.s version.o: EXTRA_CPPFLAGS = \
16781678
'-DGIT_VERSION="$(GIT_VERSION)"' \
16791679
'-DGIT_USER_AGENT=$(GIT_USER_AGENT_CQ_SQ)'
16801680

1681+
ifeq (,$(BUILT_IN_WRAPPER))
16811682
$(BUILT_INS): git$X
16821683
$(QUIET_BUILT_IN)$(RM) $@ && \
16831684
ln $< $@ 2>/dev/null || \
16841685
ln -s $< $@ 2>/dev/null || \
16851686
cp $< $@
1687+
else
1688+
$(BUILT_INS): $(BUILT_IN_WRAPPER)
1689+
$(QUIET_BUILT_IN)$(RM) $@ && \
1690+
cp $< $@
1691+
endif
16861692

16871693
common-cmds.h: ./generate-cmdlist.sh command-list.txt
16881694

@@ -2245,6 +2251,24 @@ profile-install: profile
22452251
profile-fast-install: profile-fast
22462252
$(MAKE) install
22472253

2254+
ifeq (,$(BUILT_IN_WRAPPER))
2255+
LN_OR_CP_BUILT_IN_BINDIR = \
2256+
test -z "$(NO_INSTALL_HARDLINKS)" && \
2257+
ln "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \
2258+
ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \
2259+
cp "$$bindir/git$X" "$$bindir/$$p" || exit;
2260+
LN_OR_CP_BUILT_IN_EXECDIR = \
2261+
test -z "$(NO_INSTALL_HARDLINKS)" && \
2262+
ln "$$exectir/git$X" "$$exectir/$$p" 2>/dev/null || \
2263+
ln -s "git$X" "$$exectir/$$p" 2>/dev/null || \
2264+
cp "$$exectir/git$X" "$$exectir/$$p" || exit;
2265+
else
2266+
LN_OR_CP_BUILT_IN_BINDIR = \
2267+
cp "$(BUILT_IN_WRAPPER)" "$$bindir/$$p" || exit;
2268+
LN_OR_CP_BUILT_IN_EXECDIR = \
2269+
cp "$(BUILT_IN_WRAPPER)" "$$execdir/$$p" || exit;
2270+
endif
2271+
22482272
install: all
22492273
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'
22502274
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
@@ -2283,17 +2307,11 @@ endif
22832307
} && \
22842308
for p in $(filter $(install_bindir_programs),$(BUILT_INS)); do \
22852309
$(RM) "$$bindir/$$p" && \
2286-
test -z "$(NO_INSTALL_HARDLINKS)" && \
2287-
ln "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \
2288-
ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \
2289-
cp "$$bindir/git$X" "$$bindir/$$p" || exit; \
2310+
$(LN_OR_CP_BUILT_IN_BINDIR) \
22902311
done && \
22912312
for p in $(BUILT_INS); do \
22922313
$(RM) "$$execdir/$$p" && \
2293-
test -z "$(NO_INSTALL_HARDLINKS)" && \
2294-
ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
2295-
ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
2296-
cp "$$execdir/git$X" "$$execdir/$$p" || exit; \
2314+
$(LN_OR_CP_BUILT_IN_EXECDIR) \
22972315
done && \
22982316
remote_curl_aliases="$(REMOTE_CURL_ALIASES)" && \
22992317
for p in $$remote_curl_aliases; do \

0 commit comments

Comments
 (0)