Skip to content

Commit e1e50b0

Browse files
patthoytsdscho
authored andcommitted
remote-http(s): Support SOCKS proxies
With this patch we properly support SOCKS proxies, configured e.g. like this: git config http.proxy socks5://192.168.67.1:32767 Without this patch, Git mistakenly tries to use SOCKS proxies as if they were HTTP proxies, resulting in a error message like: fatal: unable to access 'http://.../': Proxy CONNECT aborted This patch was required to work behind a faulty AP and scraped from http://stackoverflow.com/questions/15227130/#15228479 and guarded with an appropriate cURL version check by Johannes Schindelin. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent b9ca6c6 commit e1e50b0

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

http.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,17 @@ static CURL *get_curl_handle(void)
407407
curl_easy_setopt(result, CURLOPT_PROXY, curl_http_proxy);
408408
#if LIBCURL_VERSION_NUM >= 0x070a07
409409
curl_easy_setopt(result, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
410+
#endif
411+
#if LIBCURL_VERSION_NUM >= 0x071800
412+
if (starts_with(curl_http_proxy, "socks5"))
413+
curl_easy_setopt(result,
414+
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS5);
415+
else if (starts_with(curl_http_proxy, "socks4a"))
416+
curl_easy_setopt(result,
417+
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS4A);
418+
else if (starts_with(curl_http_proxy, "socks"))
419+
curl_easy_setopt(result,
420+
CURLOPT_PROXYTYPE, CURLPROXY_SOCKS4);
410421
#endif
411422
}
412423

0 commit comments

Comments
 (0)