Skip to content

Commit e5ca291

Browse files
derrickstoleegitster
authored andcommitted
t1092: document bad sparse-checkout behavior
There are several situations where a repository with sparse-checkout enabled will act differently than a normal repository, and in ways that are not intentional. The test t1092-sparse-checkout-compatibility.sh documents some of these deviations, but a casual reader might think these are intentional behavior changes. Add comments on these tests that make it clear that these behaviors should be updated. Using 'NEEDSWORK' helps contributors find that these are potential areas for improvement. Helped-by: Elijah Newren <[email protected]> Reviewed-by: Elijah Newren <[email protected]> Signed-off-by: Derrick Stolee <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent f8fe49e commit e5ca291

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

t/t1092-sparse-checkout-compatibility.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,8 @@ test_expect_failure 'blame with pathspec outside sparse definition' '
392392
test_all_match git blame deep/deeper2/deepest/a
393393
'
394394

395-
# TODO: reset currently does not behave as expected when in a
396-
# sparse-checkout.
395+
# NEEDSWORK: a sparse-checkout behaves differently from a full checkout
396+
# in this scenario, but it shouldn't.
397397
test_expect_failure 'checkout and reset (mixed)' '
398398
init_repos &&
399399
@@ -403,8 +403,8 @@ test_expect_failure 'checkout and reset (mixed)' '
403403
test_all_match git reset update-folder2
404404
'
405405

406-
# Ensure that sparse-index behaves identically to
407-
# sparse-checkout with a full index.
406+
# NEEDSWORK: a sparse-checkout behaves differently from a full checkout
407+
# in this scenario, but it shouldn't.
408408
test_expect_success 'checkout and reset (mixed) [sparse]' '
409409
init_repos &&
410410
@@ -524,6 +524,8 @@ test_expect_success 'sparse-index is not expanded' '
524524
test_region ! index ensure_full_index trace2.txt
525525
'
526526

527+
# NEEDSWORK: a sparse-checkout behaves differently from a full checkout
528+
# in this scenario, but it shouldn't.
527529
test_expect_success 'reset mixed and checkout orphan' '
528530
init_repos &&
529531

0 commit comments

Comments
 (0)