Merge branch 'rs/column-leakfix' into next

gitster · gitster · commit e5d5fe1deb6f · 2023-12-09T16:42:21.000-08:00
Leakfix.

* rs/column-leakfix:
  column: release strbuf and string_list after use
diff --git a/builtin/column.c b/builtin/column.c
@@ -56,5 +56,7 @@ int cmd_column(int argc, const char **argv, const char *prefix)
 		string_list_append(&list, sb.buf);
 
 	print_columns(&list, colopts, &copts);
+	strbuf_release(&sb);
+	string_list_clear(&list, 0);
 	return 0;
 }
diff --git a/t/t9002-column.sh b/t/t9002-column.sh
@@ -1,6 +1,7 @@
 #!/bin/sh
 
 test_description='git column'
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'setup' '

Original file line number	Diff line number	Diff line change
`@@ -56,5 +56,7 @@ int cmd_column(int argc, const char *argv, const char prefix)`
`56`	`56`	`string_list_append(&list, sb.buf);`
`57`	`57`
`58`	`58`	`print_columns(&list, colopts, &copts);`
	`59`	`+ strbuf_release(&sb);`
	`60`	`+ string_list_clear(&list, 0);`
`59`	`61`	`return 0;`
`60`	`62`	`}`