Skip to content

Commit e66dc0c

Browse files
mackylegitster
authored andcommitted
log.c: fix translation markings
The parse_options API expects an array of alternative usage lines to which it automatically ads the language-appropriate "or" when displaying. Each of these options is marked for translation with N_ and then later translated when gettext is called on each element of the array. Since the N_ macro just expands to its argument, if two N_-marked strings appear next to each other without being separated by anything else such as a comma, the preprocessor will join them into one string. In that case two separate strings get marked for translation, but at runtime they have been joined into a single string passed to gettext which then fails to get translated because the combined string was never marked for translation. Fix this by properly separating the two N_ marked strings with a comma and removing the embedded "\n" and " or:" that are properly supplied by the parse_options API. Signed-off-by: Kyle J. McKay <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9a8c2b6 commit e66dc0c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

builtin/log.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ static const char *fmt_patch_subject_prefix = "PATCH";
3838
static const char *fmt_pretty;
3939

4040
static const char * const builtin_log_usage[] = {
41-
N_("git log [<options>] [<revision range>] [[--] <path>...]\n")
42-
N_(" or: git show [options] <object>..."),
41+
N_("git log [<options>] [<revision range>] [[--] <path>...]"),
42+
N_("git show [options] <object>..."),
4343
NULL
4444
};
4545

0 commit comments

Comments
 (0)