Skip to content

Commit e76ae33

Browse files
committed
Merge branch 'jk/make-protocol-v2-the-default'
The transport protocol v2 has become the default again. * jk/make-protocol-v2-the-default: protocol: re-enable v2 protocol by default
2 parents b28919c + eb04975 commit e76ae33

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

Documentation/config/feature.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ feature.experimental::
1414
+
1515
* `fetch.negotiationAlgorithm=skipping` may improve fetch negotiation times by
1616
skipping more commits at a time, reducing the number of round trips.
17-
+
18-
* `protocol.version=2` speeds up fetches from repositories with many refs by
19-
allowing the client to specify which refs to list before the server lists
20-
them.
2117

2218
feature.manyFiles::
2319
Enable config options that optimize for repos with many files in the

Documentation/config/protocol.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ protocol.version::
4848
If set, clients will attempt to communicate with a server
4949
using the specified protocol version. If the server does
5050
not support it, communication falls back to version 0.
51-
If unset, the default is `0`, unless `feature.experimental`
52-
is enabled, in which case the default is `2`.
51+
If unset, the default is `2`.
5352
Supported versions:
5453
+
5554
--

protocol.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ static enum protocol_version parse_protocol_version(const char *value)
1717
enum protocol_version get_protocol_version_config(void)
1818
{
1919
const char *value;
20-
int val;
2120
const char *git_test_k = "GIT_TEST_PROTOCOL_VERSION";
2221
const char *git_test_v;
2322

@@ -31,9 +30,6 @@ enum protocol_version get_protocol_version_config(void)
3130
return version;
3231
}
3332

34-
if (!git_config_get_bool("feature.experimental", &val) && val)
35-
return protocol_v2;
36-
3733
git_test_v = getenv(git_test_k);
3834
if (git_test_v && *git_test_v) {
3935
enum protocol_version env = parse_protocol_version(git_test_v);
@@ -43,7 +39,7 @@ enum protocol_version get_protocol_version_config(void)
4339
return env;
4440
}
4541

46-
return protocol_v0;
42+
return protocol_v2;
4743
}
4844

4945
enum protocol_version determine_protocol_version_server(void)

0 commit comments

Comments
 (0)