fixup! Win32: symlink: add support for symlinks to directories

Change the way how directory symlinks are detected by trying to
open the link's target instead of the link itself.

It seems that Windows 10 1803 (April 2018 Update) does not allow to call
CreateFile on a link of a wrong type. If a file symlink points to a directory
an attempt to open it with CreateFile causes an ERROR_ACCESS_DENIED.
This behavior is different in previous version of Windows 10 (CreateFile
opens the incorrect link without complaining), that's why it worked fine
before.

This fixes #1646

Signed-off-by: Michał Dudak <[email protected]>

Author: michaldudak

compat/mingw.c

@@ -297,7 +297,7 @@ static enum phantom_symlink_result process_phantom_symlink(
 		return PHANTOM_SYMLINK_DONE;
 
 	/* let Windows resolve the link by opening it */
-	hnd = CreateFileW(wlink, 0,
+	hnd = CreateFileW(wtarget, 0,
 			FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL,
 			OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, NULL);
 	if (hnd == INVALID_HANDLE_VALUE) {