Skip to content

Commit ef3c42a

Browse files
ismailGit for Windows Build Agent
authored andcommitted
Enable DEP and ASLR
Enable DEP (Data Execution Prevention) and ASLR (Address Space Layout Randomization) support. This applies to both 32bit and 64bit builds and makes it substantially harder to exploit security holes in Git by offering a much more unpredictable attack surface. ASLR interferes with GDB's ability to set breakpoints. A similar issue holds true when compiling with -O2 (in which case single-stepping is messed up because GDB cannot map the code back to the original source code properly). Therefore we simply enable ASLR only when an optimization flag is present in the CFLAGS, using it as an indicator that the developer does not want to debug in GDB anyway. Signed-off-by: İsmail Dönmez <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 1b54f49 commit ef3c42a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

config.mak.uname

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,6 +572,12 @@ else
572572
ifeq ($(shell expr "$(uname_R)" : '2\.'),2)
573573
# MSys2
574574
prefix = /usr/
575+
# Enable DEP
576+
BASIC_LDFLAGS += -Wl,--nxcompat
577+
# Enable ASLR (unless debugging)
578+
ifneq (,$(findstring -O,$(CFLAGS)))
579+
BASIC_LDFLAGS += -Wl,--dynamicbase
580+
endif
575581
ifeq (MINGW32,$(MSYSTEM))
576582
prefix = /mingw32
577583
HOST_CPU = i686

0 commit comments

Comments
 (0)