Skip to content

Commit f28bcec

Browse files
peffgitster
authored andcommitted
t/gitweb-lib.sh: drop confusing quotes
Some variables assignments in gitweb_run() look like this: FOO=""$1"" The extra quotes aren't doing anything. Each set opens and closes an empty string, and $1 is actually outside of any double-quotes (which is OK, because variable assignment does not do whitespace splitting on the expanded value). Let's drop them, as they're simply confusing. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0eba60c commit f28bcec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/gitweb-lib.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ gitweb_run () {
5858
GATEWAY_INTERFACE='CGI/1.1'
5959
HTTP_ACCEPT='*/*'
6060
REQUEST_METHOD='GET'
61-
QUERY_STRING=""$1""
62-
PATH_INFO=""$2""
61+
QUERY_STRING=$1
62+
PATH_INFO=$2
6363
export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \
6464
QUERY_STRING PATH_INFO
6565

0 commit comments

Comments
 (0)