Merge branch 'js/mingw-needs-hiding-fix'

gitster · gitster · commit f2db52c46b79 · 2019-10-30T15:13:13.000+09:00
Fix for a (rather old) buffer-overrun bug.

* js/mingw-needs-hiding-fix:
  mingw: avoid a buffer overrun in `needs_hiding()`
diff --git a/compat/mingw.c b/compat/mingw.c
@@ -363,6 +363,8 @@ static inline int needs_hiding(const char *path)
 			/* ignore trailing slashes */
 			if (*path)
 				basename = path;
+			else
+				break;
 		}
 
 	if (hide_dotfiles == HIDE_DOTFILES_TRUE)

Original file line number	Diff line number	Diff line change
`@@ -363,6 +363,8 @@ static inline int needs_hiding(const char *path)`
`363`	`363`	`/* ignore trailing slashes */`
`364`	`364`	`if (*path)`
`365`	`365`	`basename = path;`
	`366`	`+ else`
	`367`	`+ break;`
`366`	`368`	`}`
`367`	`369`
`368`	`370`	`if (hide_dotfiles == HIDE_DOTFILES_TRUE)`