Skip to content

Commit f36b8cb

Browse files
joshheinrichsgitster
authored andcommitted
git-config.1: remove value from positional args in unset usage
The synopsis for `git config unset` mentions two positional arguments: `<name>` and `<value>`. While the first argument is correct, the second is not. Users are expected to provide the value via `--value=<value>`. Remove the positional argument. The `--value=<value>` option is already documented correctly, so this is all we need to do to fix the documentation. Signed-off-by: Josh Heinrichs <[email protected]> Reviewed-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 777489f commit f36b8cb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Documentation/git-config.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ SYNOPSIS
1212
'git config list' [<file-option>] [<display-option>] [--includes]
1313
'git config get' [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>
1414
'git config set' [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>
15-
'git config unset' [<file-option>] [--all] [--value=<value>] [--fixed-value] <name> <value>
15+
'git config unset' [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>
1616
'git config rename-section' [<file-option>] <old-name> <new-name>
1717
'git config remove-section' [<file-option>] <name>
1818
'git config edit' [<file-option>]

builtin/config.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ static const char *const builtin_config_usage[] = {
1919
N_("git config list [<file-option>] [<display-option>] [--includes]"),
2020
N_("git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>"),
2121
N_("git config set [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>"),
22-
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name> <value>"),
22+
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>"),
2323
N_("git config rename-section [<file-option>] <old-name> <new-name>"),
2424
N_("git config remove-section [<file-option>] <name>"),
2525
N_("git config edit [<file-option>]"),
@@ -43,7 +43,7 @@ static const char *const builtin_config_set_usage[] = {
4343
};
4444

4545
static const char *const builtin_config_unset_usage[] = {
46-
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name> <value>"),
46+
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>"),
4747
NULL
4848
};
4949

0 commit comments

Comments
 (0)